Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clue scrolls rebalancing #6111

Merged
merged 18 commits into from
Nov 16, 2024
Merged

Clue scrolls rebalancing #6111

merged 18 commits into from
Nov 16, 2024

Conversation

Arodab
Copy link
Contributor

@Arodab Arodab commented Oct 11, 2024

Description:

Clues in OSB are completed much slower compared to OSRS. This PR updates the boosts and base clue timers to match the rates found in the Efficient Hours Collected (EHC) spreadsheet from the Log Hunters discord.

Changes:

-Added boost for filled STASH units.
-Added boosts for Skull Sceptre to beginner/easy clues.
-Added boosts for Book of the Dead and combat stats to hard/elite/master clues.
-Increased boosts across some items that previously boosted clues.
-Adjusted base clue times for better balance due to global boosts.
-Increased minion learning cap to 25%, because experience completing clues is arguably more important than any item.

New rates:
Beginner: 50/hr
Easy: 45/hr
Medium: 30/hr
Hard: 20/hr
Elite: 18/hr
Master: 8/hr

Other checks:

  • I have tested all my changes thoroughly.

@gc
Copy link
Collaborator

gc commented Oct 12, 2024

Can you post the new rates? did testers give feedback on it?

@Arodab
Copy link
Contributor Author

Arodab commented Oct 12, 2024

Can you post the new rates? did testers give feedback on it?

New rates are very slightly lower than the ones in the spreadsheet (off by less than 1/hr):

Beginner: 50/hr
Easy: 45/hr
Medium: 30/hr
Hard: 20/hr
Elite: 10/hr
Master: 6/hr

I tested it myself, can post trips somewhere if you want, but feedback seemed mostly positive from bso-general. Some people didn't like me removing weekend boost. I still stand by it since it's a huge buff to old rates already, we don't really need another 10%, but I could put it back. Happy to nerf it a bit too if you feel it's too much, but these are the rates people get in OSRS.

@gc
Copy link
Collaborator

gc commented Nov 8, 2024

Most important thing for this is if testers agree with the new rates.

@Arodab
Copy link
Contributor Author

Arodab commented Nov 9, 2024

Most important thing for this is if testers agree with the new rates.

The only argument against these rates was clue juggling not being implemented in the bot yet. But I see you made a PR for it, so no one should disagree now.

@AvariceBrah
Copy link

AvariceBrah commented Nov 9, 2024

This obviously will never have ground in bso, safe to assume, yes?

Also suggestion for elite and master, make it <1 less than it currently is.

Example;
elite- 9.33/h

Master- 5.15/h

@Arodab
Copy link
Contributor Author

Arodab commented Nov 9, 2024

This obviously will never have ground in bso, safe to assume, yes?

I don't care about BSO at all, up to Magna.

Copy link
Collaborator

@gc gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run yarn dev after doing the requested changes.

// Stash Unit boost
const stashBoost = await getStashBoost(userID, clueTier.name);
boosts.push(`${stashBoost.toFixed(2)}% for built STASH Units`);
duration *= 1 - stashBoost / 100;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use our standard way instead: duration = reduceNumByPercent(duration, percentage)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACTUALLY - if this number can be negative, ignore this.

}

boosts.push(`${combatBoost.toFixed(2)}% for combat stats`);
duration *= 1 - combatBoost / 100;

This comment was marked as outdated.

src/mahoji/commands/clue.ts Show resolved Hide resolved
@gc gc merged commit 3af2561 into oldschoolgg:master Nov 16, 2024
4 checks passed
@Arodab Arodab deleted the clues branch November 27, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants