Add pages + ironman filter to lb minigames #5994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ellipsis-dev review this pr |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6ebc564 in 50 seconds
More details
- Looked at
138lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/mahoji/commands/leaderboard.ts:311
- Draft comment:
Consider using thecolumnvariable instead of hardcodingchampions_challengein the SQL query to maintain consistency and reduce future maintenance issues. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_sdbzH18Z4OyB4xVI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
gc
reviewed
Aug 10, 2024
…into iron-filter-minigames
TastyPumPum
added
Status: Waiting For Review
and removed
Status: Needs Information
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added pagination and ironman filter to minigames leaderboard in
src/mahoji/commands/leaderboard.ts.Key points:
src/mahoji/commands/leaderboard.ts.ironmanOnlyparameter tominigamesLbfunction for filtering ironman-only results.doMenuWrapperanddoMenufunctions to support new pagination feature.leaderboardCommandto includeironmanOnlyOption.Generated with ❤️ by ellipsis.dev