Modals sample code #5990
Closed
Modals sample code #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add price abuse check to packaged buyables.
…ngs admin command. (#5748)
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e350f74 in 35 seconds
More details
- Looked at
56lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_8I0cCen5u0VoHTdy
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -31,6 +38,36 @@ export const bsCommand: OSBMahojiCommand = { | |||
| format?: BankFormat; | |||
| }> | |||
| ) => { | |||
| // Create the modal | |||
There was a problem hiding this comment.
The addition of a modal interaction here significantly alters the functionality of the bs command. The modal collects information that seems unrelated to the command's original purpose (searching a user's bank). Please clarify if this change aligns with the intended functionality and ensure it doesn't confuse users or disrupt the user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
Other checks: