Chambers of Xeric QOL & fakemass

[nwjgit]

Description:

Update various aspects of CoX to closer match ingame times and boosts.
Add an option to fakemass (similar to nex/tob solo).

Changes:

• add the option type of fakemass
  • Specify the number of fake users with max_team_size (2 - 15)
  • Acts as a normal mass but checks the user for kc and boosts similar to tob/nex solo
• Update CoX speed tasks to use actual trip duration
• Update bis melee, range, mage gear (this affects gearscore)
• Update item boosts
  • add scythe boost + charge usage
• Add a new command /raid cox itemboosts to check your itemboosts for CoX
• Add ammo checks and usage
• Add crystal pick as simItem to dragonpickaxe
• Update mass forming message to show 5 minutes vice 2 minutes
• add two new variables to RaidsOptions for better flexibility isFakeMass maxSizeInput & update repeatStoredTrip
• Update testpotato gear for bis CoX and also gives 10000 of any range ammo specified.

Updated Times for CoX:

Assumptions: 1 raid trip, 100% itemboost, 100% kc boost, 100% gearscore.

solo: 16m 42s - 18m 28s (CA time: < 17m 00s)
2man: 14m 39s - 16m 12s
3man: 13m 43s - 15m 09s (CA time: < 14m 30s)
4man: 12m 55s - 14m 17s
5man: 12m 08s - 13m 25s (CA time: < 12m 30s)
6man or higher: same as 5man times

cm solo: 30m 12s - 33m 23s (CA time: < 38m 30s)
cm 2man: 20m 24s - 22m 33s
cm 3man: 21m 38s - 23m 55s (CA time: < 27m 00s)
cm 4man: 20m 24s - 22m 33s
cm 5man: 19m 09s - 21m 10s (CA time: < 25m 00s)
6man or higher: same as 5man times

Other checks:

• I have tested all my changes thoroughly.
• 2 rounds of testing was done in testing server with testers (all feedback/bugs were addressed and or fixed)

closes: #1811
closes: #1769
closes: #2151
closes: #1850

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 8d13a3c in 50 seconds

More details

• Looked at 1353 lines of code in 11 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_OCnIlva1edmqdWcT

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The handling of fakemass by using the same user object for all positions in the array might not reflect the intended functionality of a mass where each user is distinct. This could affect loot distribution and point calculations. Consider revising how fakemass is handled to ensure it aligns with the expected behavior of a mass raid.

[gc]

Will merge after conflicts fixed (assuming its been tested and such)

[nwjgit]

Updated.
This has been tested a few times with testers and the updated times are listed in the description above.
I also just did a quick test as of posting this message and everything is still working as intended.