Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fishing rework #5954

Closed
wants to merge 0 commits into from
Closed

Fishing rework #5954

wants to merge 0 commits into from

Conversation

Arodab
Copy link
Contributor

@Arodab Arodab commented Jul 14, 2024

Description:

The fishing skill in the bot currently works nothing like in the real game, where fishing spots can have different types of fish. This PR fixes that and changes fishing to a tick system, allowing methods like 2t swordfish and 3t barb to be added. It also allows spirit flakes to be used for a chance to catch more fish.

Changes:

  • Grouped fish into fishing spots, exactly like in osrs (e.g. Tuna/Swordfish).
  • Added optional powerfish and spirit_flakes parameters to the fish command. If powerfish is True, the minion will receive more exp at the cost of not banking the fish, and will use tick manipulation methods if applicable.
  • Removed the +9min boost from having a fish barrel only if powerfishing, trips are still longer if banking the fish.
  • Removed other nonsense boosts like pearl fishing rods, and added dragon/crystal harpoon boosts only for fish that they actually affect.

Other checks:

  • I have tested all my changes thoroughly.

@Arodab Arodab force-pushed the master branch 2 times, most recently from 0312146 to 4a32343 Compare August 16, 2024 04:08
@Arodab Arodab closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant