Allow Fletching at Sepulchre #5952
Conversation
|
@ellipsis-dev can you review this pr |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 64d7f12 in 43 seconds
More details
- Looked at
281lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/lib/types/minions.ts:384
- Draft comment:
The PR description indicates that the changes have not been tested. It's crucial to perform thorough testing, especially for new features that affect game mechanics, to ensure that the implementation works as expected and does not introduce bugs. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_QDmtuaaclVmxnhBO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
@ellipsis-dev can you review this pr |
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to f0b2903 in 49 seconds
More details
- Looked at
421lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_uxXYnzPl01kFVXLx
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
@ellipsis-dev can you review and summarise this pr and delete all the previous reviews |
|
Sorry, I don't know how to help with that. If you tag me (@ellipsis-dev) in a comment, I can do one of these things (but not multiple at once):
I am able to see previous issue comments for context. |
|
@ellipsis-dev review and summarize this pull request |
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e8cfabc in 51 seconds
More details
- Looked at
420lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_3tCqUCdtWaS2XJUL
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
src/lib/types/minions.ts
Outdated
| @@ -380,6 +381,10 @@ export interface TitheFarmActivityTaskOptions extends MinigameActivityTaskOption | |||
| export interface SepulchreActivityTaskOptions extends MinigameActivityTaskOptions { | |||
| type: 'Sepulchre'; | |||
| floors: number[]; | |||
| fletch?: { | |||
| fletchable: Fletchable; | |||
There was a problem hiding this comment.
ActivityTaskOptions are stored in the database as json, this is storing the full fletchable object there. Like how we use monsterID instead of putting the full monster data, anything that goes in activity task options should use an ID. So this needs to be changed.
TastyPumPum
added
Status: Waiting For Changes
and removed
Status: Waiting For Review
labels
…into fletch-sepulchre
Allows the fletching of darts, arrows and bolts during Sepulchre trips
Summary:
Allows fletching of darts, arrows, and bolts during Sepulchre trips by updating command options, task options, and task execution logic.
Key points:
src/lib/types/minions.tsto includefletchoption inSepulchreActivityTaskOptions.src/mahoji/commands/minigames.tsto addfletchingoption insepulchrecommand.sepulchreCommandinsrc/mahoji/lib/abstracted_commands/sepulchreCommand.tsto handle fletching logic.sepulchreTaskinsrc/tasks/minions/minigames/sepulchreActivity.tsto process fletching during Sepulchre trips.zeroTimeFletchablesarray insrc/lib/skilling/skills/fletching/fletchables/index.tsto list fletchable items that can be crafted during Sepulchre trips.src/lib/skilling/skills/fletching/fletchables/slayer.tsto export individual fletchable items.Generated with ❤️ by ellipsis.dev