Update setup steps to mention db schema update #5947
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to eaa3f13 in 28 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_LdptXyvew8wS8eoN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -15,7 +15,7 @@ This assumes you are using VSCode as your IDE. If you have errors or issues, you | |||
| 2. Install [Postgres 16](https://www.postgresql.org/download/) and PGAdmin4 for interacting with postgres (optional, but helpful) | |||
| 3. Install Yarn using: `npm i -g yarn` | |||
| 4. Clone the repo: `git clone https://github.com/oldschoolgg/oldschoolbot.git` | |||
| 5. Run `corepack enable` and `yarn` in the root of the repo. | |||
| 5. Run the following commands in the root of the repo: `corepack enable`, `yarn`, `npx prisma db push` and `npx prisma db push --schema ./prisma/robochimp.prisma` | |||
There was a problem hiding this comment.
The command npx prisma db push is duplicated in the setup instructions. This is likely a mistake as running it twice consecutively does not add any value and could lead to confusion. Consider removing the duplicate command to streamline the setup process.
| 5. Run the following commands in the root of the repo: `corepack enable`, `yarn`, `npx prisma db push` and `npx prisma db push --schema ./prisma/robochimp.prisma` | |
| 5. Run the following commands in the root of the repo: `corepack enable`, `yarn`, `npx prisma db push --schema ./prisma/robochimp.prisma` |
There was a problem hiding this comment.
It's like this because --schema doesn't seem to support wildcards in its path so you have to do one command for osb_test and another command for robotchimp_test
|
I believe Magna is attempting to make this generate automatically with https://github.com/oldschoolgg/oldschoolbot/blob/master/src/scripts/build.ts#L67 I messaged him in the dev channel about the issues i'm facing with it. https://discord.com/channels/342983479501389826/648196527294251020/1260987365992956015 |
Description:
Updated the final step in the Environment section to mention bringing the databases up to date with their schema.
yarn startwill complain if you don't update your schemas.Changes:
A line in SETUP.md
Other checks: