Brimstone key from Superior #5942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ellipsis-dev review this pr |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7a446ca in 20 seconds
More details
- Looked at
61lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/tasks/minions/monsterActivity.ts:260
- Draft comment:
The implementation correctly adds a brimstone key for each superior monster killed while on a Konar task, as intended in the PR. - Reason this comment was not posted:
Confidence changes required:0%
The PR description states that a brimstone key should be guaranteed from a superior monster when on a Konar task. The implementation inmonsterActivity.tscorrectly adds a brimstone key for each superior monster killed under these conditions. However, the logic should ensure that this only happens when a superior is actually encountered and killed, which is handled by checkingnewSuperiorCountbefore adding the key. This seems correct as per the PR's intent.
Workflow ID: wflow_UfEsNHce6i5bbKFE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
gc
reviewed
Aug 6, 2024
Comment on lines
+184
to
+185
| let isUsingKonar = false; | ||
| if (isOnTask && usersTask.slayerMaster.id === 5) isUsingKonar = true; |
There was a problem hiding this comment.
This should be changed to be the same as these:
usingCannon: !usingCannon ? undefined : usingCannon,
cannonMulti: !cannonMulti ? undefined : cannonMulti,
and change the type to isUsingKonar?: true;, so its either undefined, or true.
This is just to not have unnecessary stuff in the data in the db.
TastyPumPum
added
Status: Waiting For Changes
and removed
Status: Waiting For Review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarantees a brimstone key drop from a superior on a konar slayer task
Summary:
Guarantees a Brimstone key drop from a superior monster on a Konar Slayer task by adding the
isUsingKonarflag and updating loot logic.Key points:
isUsingKonarflag toMonsterActivityTaskOptionsinsrc/lib/types/minions.ts.minionKillCommandinsrc/mahoji/lib/abstracted_commands/minionKill.tsto setisUsingKonarwhen on a Konar Slayer task.monsterTaskinsrc/tasks/minions/monsterActivity.tsto add a Brimstone key to the loot ifisUsingKonaris true and a superior monster is killed.Generated with ❤️ by ellipsis.dev
closes: #5999