Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quantity to Zalcano #5937

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

TastyPumPum
Copy link
Contributor

Allows users to specify the quantity of Zalcano. If no quantity is provided do a max trip as before.

  • I have tested all my changes thoroughly.

Allows users to specify the quantity of Zalcano. If no quantity is provided do a max trip as before.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 021cf45 in 24 seconds

More details
  • Looked at 76 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_huqec62Nb6ofjgLq


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

src/mahoji/lib/abstracted_commands/zalcanoCommand.ts Outdated Show resolved Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@gc gc merged commit 4aa1c0a into oldschoolgg:master Jul 5, 2024
3 checks passed
@TastyPumPum TastyPumPum deleted the zalcano-quantity branch July 5, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants