Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSO Wildy Changes #5926

Merged
merged 2 commits into from
Jul 2, 2024
Merged

BSO Wildy Changes #5926

merged 2 commits into from
Jul 2, 2024

Conversation

TastyPumPum
Copy link
Contributor

@TastyPumPum TastyPumPum commented Jun 18, 2024

Removes the requirement of equipping items in the wildy gear slot to get the relevant boost (with the exception of the hellfire boost)

Follows on from the poll here - https://discord.com/channels/342983479501389826/1032668754561224734/1252665746614390829

image

  • I have tested all my changes thoroughly.

🚀 This description was created by Ellipsis for commit 916b1d3

Summary:

Removed the requirement for equipping items in the wilderness gear slot for boosts, except for the Hellfire boost, and updated relevant functions and files accordingly.

Key points:

  • Removed requirement for equipping items in the wilderness gear slot for boosts, except Hellfire boost.
  • Updated src/lib/minions/data/killableMonsters/custom/demiBosses.ts to set canBePked for Malygos and Treebeard.
  • Modified src/mahoji/lib/abstracted_commands/minionKill.ts to remove wilderness gear checks in applyDragonBoost, applyBlackMaskBoost, calculateSalveAmuletBoost, and other relevant functions.
  • Updated resolveAvailableItemBoosts in src/mahoji/mahojiSettings.ts to remove isInWilderness parameter and related checks.

Generated with ❤️ by ellipsis.dev

@TastyPumPum
Copy link
Contributor Author

@ellipsis-dev review this pr

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 916b1d3 in 2 minutes and 5 seconds

More details
  • Looked at 164 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_VlWhiNbL3cswIByn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@gc gc merged commit c2f4723 into oldschoolgg:bso Jul 2, 2024
5 checks passed
@TastyPumPum TastyPumPum deleted the wildy-update-bso branch July 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants