Colosseum #5922
Colosseum #5922
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 09c72a3 in 1 minute and 14 seconds
More details
- Looked at
885lines of code in8files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_vUF6a4BVeWX738Qs
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
src/lib/colosseum.ts
Outdated
| console.log(`Min: ${finishAttemptAmounts[0]}, Max: ${finishAttemptAmounts[finishAttemptAmounts.length - 1]}`); | ||
| } | ||
|
|
||
| simulateColosseumRuns(); |
There was a problem hiding this comment.
Consider wrapping the simulateColosseumRuns function call in a specific function or condition to prevent unintended executions when the module is imported.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on e39656e in 33 seconds
More details
- Looked at
36lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_rND8CdXkkg2WrvIT
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const itemsTheyHave = sunfireItems.filter(id => user.cl.has(id)); | ||
| if (missingItems.length > 0) { | ||
| for (const item of sunfireItems) { | ||
| if (loot.has(item) && itemsTheyHave.includes(item)) { |
There was a problem hiding this comment.
The logic for replacing items in the loot might unintentionally replace an item with itself, as randArrItem(missingItems) could select the same item being removed. Consider filtering out the current item from missingItems before selecting a random item to ensure a different item is chosen.
Description:
Changes:
Other checks: