Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crystal Impling Hunting #5771

Merged
merged 13 commits into from
Apr 25, 2024
Merged

Add Crystal Impling Hunting #5771

merged 13 commits into from
Apr 25, 2024

Conversation

TastyPumPum
Copy link
Contributor

Adds a way to seek out crystal implings and hunt them. Currently we have to do priff content and the rate of obtaining them is quite rare. This gives players a way to specifically hunt them.

  • I have tested all my changes thoroughly.

Adds a way to seek out crystal implings and hunt them. Currently we have to do priff content and the rate of obtaining them is quite rare. This gives players a way to specifically hunt them.
@TastyPumPum TastyPumPum marked this pull request as draft March 12, 2024 09:05
@TastyPumPum TastyPumPum marked this pull request as ready for review March 12, 2024 21:58
Copy link
Collaborator

@gc gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the if (crystalImpling)'s. It's bad for maintainability.

@TastyPumPum
Copy link
Contributor Author

Not sure about the if (crystalImpling)'s. It's bad for maintainability.

Have you got any ideas? I think it would be best for users to be under /hunt, but maybe it could have its own abstracted command file and activity file then?

It's just quite different to any other hunted creatures really.

@gc gc merged commit 882f61e into oldschoolgg:master Apr 25, 2024
5 checks passed
@TastyPumPum TastyPumPum deleted the crystal-imps branch April 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants