Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTED]Updated fishing contest button to check for the items of both locations #5765

Merged
merged 16 commits into from
May 2, 2024

Conversation

I-am-TURBO
Copy link
Contributor

@I-am-TURBO I-am-TURBO commented Mar 9, 2024

Description:

The button just calls the normal fishing contest command with no location option causing the bot to to respond you need so many of bait to fish at location instead of checking if you have items for the other location

Screenshot_20240308_011105_Discord.jpg

This image is an example of what it currently does now if you don't have bait before the location that it searches by default

i updated the fishingContestStartCommand() function to check for the items of both locations

all-in-all this will get rid of having to manually send the command for the location you do have items for.

mad thanks to @themrrobert for this.

Changes:

  • changed if (!loc)... to iterate over all validLoc items putting current value in location

  • moved the section of code that registers quantity as one above the location code so that way it reads quantity instead of a number when it comes to the amount of bait needed

  • linked the buy command to BSO so people can tap/click it and it'll open buy.

  • added Beginner's to the return message if you don't own a contest rod or Beginner's tackle box (because people may have gotten confused)

Other checks:

  • I have tested all my changes thoroughly.

in this screenshot it shows he has neither item for either location, so he spawns the item needed for the 2nd location only and sends command and it went directly there as hoped for.
Screenshot_20240426_090916_Discord.jpg

changed the message you get when you don't own rod or tackle box.
SmartSelect_20240424_032409_Discord.png

Screenshot_20240424_032412_Discord.png

thank you sooo much @themrrobert for all you have done to help me on this.

@I-am-TURBO I-am-TURBO changed the title Updated fishing contest button to check for the items of both locations [TESTED]Updated fishing contest button to check for the items of both locations Apr 26, 2024
@themrrobert themrrobert merged commit f88b20a into oldschoolgg:bso May 2, 2024
5 checks passed
@I-am-TURBO I-am-TURBO deleted the fishingcontest branch May 2, 2024 05:55
@I-am-TURBO I-am-TURBO restored the fishingcontest branch May 2, 2024 10:14
@I-am-TURBO I-am-TURBO deleted the fishingcontest branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants