[TESTED]Updated fishing contest button to check for the items of both locations #5765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The button just calls the normal fishing contest command with no location option causing the bot to to respond you need so many of bait to fish at location instead of checking if you have items for the other location
This image is an example of what it currently does now if you don't have bait before the location that it searches by default
i updated the
fishingContestStartCommand()
function to check for the items of both locationsall-in-all this will get rid of having to manually send the command for the location you do have items for.
mad thanks to @themrrobert for this.
Changes:
changed
if (!loc)...
to iterate over all validLoc items putting current value inlocation
moved the section of code that registers quantity as one above the location code so that way it reads quantity instead of a number when it comes to the amount of bait needed
linked the buy command to BSO so people can tap/click it and it'll open buy.
added
Beginner's
to the return message if you don't own a contest rod or Beginner's tackle box (because people may have gotten confused)Other checks:
in this screenshot it shows he has neither item for either location, so he spawns the item needed for the 2nd location only and sends command and it went directly there as hoped for.
changed the message you get when you don't own rod or tackle box.
thank you sooo much @themrrobert for all you have done to help me on this.