Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with CL notifications #5760

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix issue with CL notifications #5760

merged 1 commit into from
Mar 8, 2024

Conversation

themrrobert
Copy link
Contributor

Description:

  • Currently, the notification saying, 'the user is Nth to finish this CL' is incorrect. It's counting all users on the leaderboard, not just users who have completed the CL.

Changes:

  • Filters the leaderboard to only count completions
  • Adds support for a local Notifications channel override for testing notifications

Other checks:

  • I have tested all my changes thoroughly.

image
image

@themrrobert themrrobert added the Type: Bug Something isn't working label Mar 8, 2024
@themrrobert themrrobert merged commit f315583 into oldschoolgg:master Mar 8, 2024
5 checks passed
@themrrobert themrrobert deleted the fix-cl-ordinals branch March 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@themrrobert