Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add price abuse check to packaged buyables. #5745

Merged

Conversation

themrrobert
Copy link
Contributor

Description:

  • An exploit was recently found where the packaged buyables were not checked for Price abuses, this allowed a price difference in menaphite clothing to lead to a massive GP dupe.

Changes:

  • Updates priceAbuses.ts to catch abuses in packaged buyables.
  • Updates buyable cost for menaphite package.
  • One of the old ironman tests had the buy + sell prices swapped.

Other checks:

  • I have tested all my changes thoroughly.

@themrrobert themrrobert merged commit f64ffb2 into oldschoolgg:master Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant