Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added energy bank filter #5623

Closed
wants to merge 0 commits into from
Closed

Added energy bank filter #5623

wants to merge 0 commits into from

Conversation

I-am-TURBO
Copy link
Contributor

@I-am-TURBO I-am-TURBO commented Feb 1, 2024 •
edited
Loading

Description:

  • added energy to bank filters

Changes:

  • made it so energy can have uppercase & lowercase E
  • made alias "en"

Other checks:

  • I have tested all my changes thoroughly.

@I-am-TURBO
Copy link
Contributor Author

I-am-TURBO commented Feb 1, 2024 •
edited
Loading

Divination Issue Thread #5602

this isn't divination filter but it's a filter that's needed imo

@gc
Copy link
Collaborator

gc commented Feb 2, 2024

This needs to be generated dynamically from the energy list.

@nwjgit
Copy link
Contributor

nwjgit commented Feb 2, 2024 

const energy = divinationEnergies.flatMap(i => i.item.id);

Will work as a dynamic solution. Just be sure to update imports and lint.

@I-am-TURBO
Copy link
Contributor Author

This needs to be generated dynamically from the energy list.

I added what jonesy posted and added the import

@I-am-TURBO I-am-TURBO closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Waiting For Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@I-am-TURBO @gc @nwjgit