Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Pickaxe #5562

Closed
wants to merge 2 commits into from
Closed

Broken Pickaxe #5562

wants to merge 2 commits into from

Conversation

Lajnux
Copy link
Contributor

@Lajnux Lajnux commented Jan 2, 2024

Description:

Added Ore Pack and Broken Pickaxe to VM

Changes:

Added Ore Pack and Broken Pickaxe to VM

Other checks:

  • I have tested all my changes thoroughly.

@nwjgit
Copy link
Contributor

nwjgit commented Jan 3, 2024

I would recommend this be handled in a different way. The Ore Pack from volcanic mine is an actual item in-game: https://oldschool.runescape.wiki/w/Ore_pack_(Volcanic_Mine) . This code auto gives the loot from the ore pack when purchased.

This would remove alot of functionality and user experience such as:

  • /lb opens openable:
  • /data name:Personal Open Stats
  • Bank log
  • Sac log
  • No functionality to the ore pack in BSO when received from a mystery box.

Having an openable function differently than 99% of other openables probably isn't the way to go.
There is already a way to easily handle openables with oldschooljs. Trying to re-invent the wheel here would just add to player confusion and frustration in my opinion.

@Lajnux
Copy link
Contributor Author

Lajnux commented Jan 3, 2024

I don't agree with this,
It adds extra unnecessary steps for the user.
We already have Ore Pack from Giant's Foundry and would have to separate them.
The Ore Pack doesn't have a CL itself, Giant's Foundry one does.
There is plenty of items that are unopenable in BSO, making extra work for a mystery box item to be openable isn't really a priority.

@nwjgit
Copy link
Contributor

nwjgit commented Jan 3, 2024

I don't agree with this, It adds extra unnecessary steps for the user. We already have Ore Pack from Giant's Foundry and would have to separate them. The Ore Pack doesn't have a CL itself, Giant's Foundry one does. There is plenty of items that are unopenable in BSO, making extra work for a mystery box item to be openable isn't really a priority.

Why make this one openable function differently than 99% of the other ones though?

@TastyPumPum
Copy link
Contributor

Dragon Pickaxe broken has been added in: #5709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants