Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RevenantsCommand file and activity #5435

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

TastyPumPum
Copy link
Contributor

@TastyPumPum TastyPumPum commented Oct 16, 2023

Move revenants into the normal minionKill/monsterActivity files, this will help streamline wildy slayer.

Allows quantity to be defined for revenants now.
Adds salve amulet boost, which is huge for revs.
Changed base times to allow for these boosts
Changed salve/blackmask/dragon hunter boosts to check for equipped gear if can Be Pked

  • I have tested all my changes thoroughly.

Move revenants into the normal minionKill/monsterActivity files, this will help streamline wildy slayer.

Allows quantity to be defined for revenants now.
Adds salve amulet boost, which is huge for revs.
Changed salve/blackmask/dragon hunter boosts to check for equipped gear if wilderness activties.
@TastyPumPum TastyPumPum changed the title Revenants Remove RevenantsCommand file and activity Oct 16, 2023
@sweep-ai
Copy link

sweep-ai bot commented Oct 16, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@gc gc merged commit 840f23e into oldschoolgg:master Oct 17, 2023
4 checks passed
@TastyPumPum TastyPumPum deleted the revenants branch October 17, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants