Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruins of Camdozaal #5431

Merged
merged 36 commits into from
Dec 10, 2023
Merged

Ruins of Camdozaal #5431

merged 36 commits into from
Dec 10, 2023

Conversation

nwjgit
Copy link
Contributor

@nwjgit nwjgit commented Oct 14, 2023

Description:

Adds Ruins of Camdozaal as an activity. Supports mining, smiting, fishing, and killing golems.
Allows the entire colectionlog for camdozaal to be completed.

Changes:

Ruins of Camdozaal (/activities camdozaal action: quantity:)

  1. Mining
  2. Smithing
  3. Fishing

The four types of golems are handled under /k
golem data is handled with: oldschoolgg/oldschooljs#351

Other checks:

@sweep-ai
Copy link

sweep-ai bot commented Oct 14, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Copy link
Contributor

@LuxrayElite LuxrayElite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things I spotted at a glance. Most of it looks good code wise

Copy link
Contributor

@LuxrayElite LuxrayElite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I mentioned on discord so you can track where I'm talking about

src/lib/skilling/skills/mining.ts Outdated Show resolved Hide resolved
src/mahoji/lib/abstracted_commands/camdozaalCommand.ts Outdated Show resolved Hide resolved
src/mahoji/lib/abstracted_commands/slayerTaskCommand.ts Outdated Show resolved Hide resolved
@gc gc merged commit e61636b into oldschoolgg:master Dec 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants