-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruins of Camdozaal #5431
Merged
Merged
Ruins of Camdozaal #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
TastyPumPum
reviewed
Oct 16, 2023
TastyPumPum
reviewed
Oct 16, 2023
LuxrayElite
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things I spotted at a glance. Most of it looks good code wise
src/tasks/minions/camdozaalActivity/camdozaalFishingActivity.ts
Outdated
Show resolved
Hide resolved
src/tasks/minions/camdozaalActivity/camdozaalFishingActivity.ts
Outdated
Show resolved
Hide resolved
src/tasks/minions/camdozaalActivity/camdozaalFishingActivity.ts
Outdated
Show resolved
Hide resolved
LuxrayElite
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things I mentioned on discord so you can track where I'm talking about
src/tasks/minions/camdozaalActivity/camdozaalFishingActivity.ts
Outdated
Show resolved
Hide resolved
nwjgit
force-pushed
the
Ruins-of-Camdozaal
branch
from
November 9, 2023 04:23
42bea25
to
b6e31b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds Ruins of Camdozaal as an activity. Supports mining, smiting, fishing, and killing golems.
Allows the entire colectionlog for camdozaal to be completed.
Changes:
Ruins of Camdozaal (/activities camdozaal action: quantity:)
The four types of golems are handled under /k
golem data is handled with: oldschoolgg/oldschooljs#351
Other checks:
More testing is probably optimal to ensure correct xp rates, and to find any bugs.
https://discord.com/channels/940758552425955348/1162793245194072074