Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerf non-zeah Blood runes #5421

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Nerf non-zeah Blood runes #5421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/invention/inventions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
const InventionFlags = ['equipped', 'bank'] as const;
type InventionFlag = (typeof InventionFlags)[number];

export enum InventionID {

Check warning on line 22 in src/lib/invention/inventions.ts

View workflow job for this annotation

GitHub Actions / ESLint 

[eslint] reported by reviewdog 🐶
'InventionID' is already declared in the upper scope on line 22 column 13.

Raw Output:
{"ruleId":"no-shadow","severity":1,"message":"'InventionID' is already declared in the upper scope on line 22 column 13.","line":22,"column":13,"nodeType":"Identifier","messageId":"noShadow","endLine":22,"endColumn":24}
SuperiorBonecrusher = 1,
SuperiorDwarfMultiCannon = 2,
SuperiorInfernoAdze = 3,
Expand Down Expand Up @@ -64,7 +64,8 @@
{ runes: ['Lava rune', 'Steam rune', 'Smoke rune'], boost: 20 },
{ runes: ['Death rune', 'Astral rune', 'Wrath rune', 'Law rune', 'Nature rune'], boost: 50 },
{ runes: ['Chaos rune', 'Cosmic rune'], boost: 60 },
{ runes: ['Blood rune', 'Soul rune'], boost: 95 },
{ runes: ['Blood rune', 'Soul rune'], boost: 65 },
{ runes: ['Blood rune (zeah)', 'Soul rune (zeah)'], boost: 95 },
{ runes: ['Elder rune'], boost: 65 }
]
},
Expand Down
2 changes: 1 addition & 1 deletion src/lib/minions/functions/darkAltarCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export async function darkAltarCommand({ user, channelID, name }: { user: MUser;
// Calculate Abyssal amulet boost:
if (user.hasEquippedOrInBank(['Abyssal amulet'])) {
const abyssalAmuletBoost = inventionBoosts.abyssalAmulet.boosts.find(b =>
b.runes.some(r => stringMatches(r, `${rune} rune`))
b.runes.some(r => stringMatches(r, `${rune} rune (zeah)`))
);
if (abyssalAmuletBoost) {
const res = await inventionItemBoost({
Expand Down