Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monthly to gains commands #5393

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Conversation

TastyPumPum
Copy link
Contributor

Move the patronMsg outside of the function to match other commands.

Add month as an option for xp_gains, clue_gains and kc_gains

  • I have tested all my changes thoroughly.

TastyPumPum and others added 2 commits September 27, 2023 20:28
Move the patronMsg outside of the function to match other commands.
Add month as an option for xp_gains, clue_gains and kc_gains
@themrrobert
Copy link
Contributor

What's the status of this PR? Is it still waiting for changes?

Also, try to keep changes withing the scope of the PR.

ie. don't put random changes into the PR that are unrelated to it; you can make a separate PR for changes to the README.md, etc.

@TastyPumPum
Copy link
Contributor Author

What's the status of this PR? Is it still waiting for changes?

Also, try to keep changes withing the scope of the PR.

ie. don't put random changes into the PR that are unrelated to it; you can make a separate PR for changes to the README.md, etc.

Need to do some final testing so waiting on my end still, not sure why the readme is being edited, it was doing it when i ran yarn lint

@gc gc merged commit 1157ee0 into oldschoolgg:master Dec 11, 2023
5 checks passed
@TastyPumPum TastyPumPum deleted the xp_gains-monthly branch December 14, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants