Skip to content

Commit

Permalink
Fix overlooked capitalization and extra full stops in fight caves
Browse files Browse the repository at this point in the history
  • Loading branch information
minimicronano committed Aug 6, 2024
1 parent 80a5d39 commit 9c3b863
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
1 change: 1 addition & 0 deletions obdocs
Submodule obdocs added at 658165
2 changes: 1 addition & 1 deletion src/mahoji/lib/abstracted_commands/fightCavesCommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function checkGear(user: MUser): string | undefined {
}

if (!user.owns(fightCavesCost)) {
return `JalYt, you need supplies to have a chance in the caves... come back with ${fightCavesCost}.`;
return `JalYt, you need supplies to have a chance in the caves... Come back with ${fightCavesCost}.`;
}

if (user.skillLevel('prayer') < 43) {
Expand Down
14 changes: 10 additions & 4 deletions src/tasks/minions/minigames/fightCavesActivity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const fightCavesTask: MinionTask = {
preJadDeathTime
)} into your attempt.${slayerMsg} The following supplies were refunded back into your bank: ${itemLootBank}.`,
await chatHeadImage({
content: `You die before you even reach TzTok-Jad... At least you tried, I give you ${tokkulReward}x Tokkul. ${attemptsStr}`,
content: `You die before you even reach TzTok-Jad... At least you tried, I give you ${tokkulReward}x Tokkul. ${attemptsStr}.`,
head: 'mejJal'
}),
data,
Expand Down Expand Up @@ -152,8 +152,8 @@ export const fightCavesTask: MinionTask = {
itemsToAdd: loot
});

const rangeXP = await user.addXP({ skillName: SkillsEnum.Ranged, amount: 47_580, duration });
const hpXP = await user.addXP({ skillName: SkillsEnum.Hitpoints, amount: 15_860, duration });
const rangeXP = await user.addXP({ skillName: SkillsEnum.Ranged, amount: 47_580, duration, minimal: true });
const hpXP = await user.addXP({ skillName: SkillsEnum.Hitpoints, amount: 15_860, duration, minimal: true });

let msg = `${rangeXP}. ${hpXP}.`;
if (isOnTask) {
Expand Down Expand Up @@ -186,7 +186,13 @@ export const fightCavesTask: MinionTask = {
}
});

const slayXP = await user.addXP({ skillName: SkillsEnum.Slayer, amount: slayerXP, duration });
const slayXP = await user.addXP({
skillName: SkillsEnum.Slayer,
amount: slayerXP,
duration,
minimal: true
});

const xpMessage = `${msg} ${slayXP}`;

msg = `Jad task completed. ${xpMessage}. \n**You've completed ${currentStreak} tasks and received ${points} points; giving you a total of ${secondNewUser.newUser.slayer_points}; return to a Slayer master.**`;
Expand Down

0 comments on commit 9c3b863

Please sign in to comment.