removed empty file & addressed feedback

oldschoolgg · Oct 16, 2023 · 1e7cd3a · 1e7cd3a
1 parent d224096
commit 1e7cd3a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 17 deletions.
diff --git a/src/lib/util/calcMaxTripLength.ts b/src/lib/util/calcMaxTripLength.ts
@@ -34,9 +34,6 @@ export function calcMaxTripLength(user: MUser, activity?: activity_type_enum) {
 		case 'Raids':
 		case 'TheatreOfBlood':
 		case 'TombsOfAmascut':
-		case 'CamdozaalMining':
-		case 'CamdozaalSmithing':
-		case 'CamdozaalFishing':
 		case 'Pickpocket':
 		case 'SoulWars':
 		case 'Cyclops': {

diff --git a/src/tasks/minions/camdozaalActivity/camdozaalFishingActivity.ts b/src/tasks/minions/camdozaalActivity/camdozaalFishingActivity.ts
@@ -87,26 +87,16 @@ export const camdozaalFishingTask: MinionTask = {
 			}
 			if (fishingRoll === 5) {
 				barroniteShards += 3;
-			}
-			if (fishingRoll !== 5) {
+			} else {
 				const fishCaught = camdozaalFishTable.roll();
-
 				if (fishCaught.has(guppy.id)) {
 					guppyCaught++;
-					continue;
-				}
-				if (fishCaught.has(cavefish.id)) {
+				  } else if (fishCaught.has(cavefish.id)) {
 					cavefishCaught++;
-					continue;
-				}
-				if (fishCaught.has(tetra.id)) {
+				  } else if (fishCaught.has(tetra.id)) {
 					tetraCaught++;
-					continue;
-				}
-				if (fishCaught.has(catfish.id)) {
+				  } else if (fishCaught.has(catfish.id)) {
 					catfishCaught++;
-					continue;
-				}
 			}
 		}
 

diff --git a/src/tasks/minions/camdozaalActivity/camdozaalGolemActivity.ts b/src/tasks/minions/camdozaalActivity/camdozaalGolemActivity.ts