Skip to content

Wildy slayer

Wildy slayer #13957

Triggered via pull request October 13, 2023 19:18
Status Success
Total duration 1m 15s
Artifacts

codequality.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
ESLint
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
ESLint: src/lib/slayer/constants.ts#L1
[eslint] reported by reviewdog 🐶 'AutoslayOptionsEnum' is already declared in the upper scope on line 1 column 13. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'AutoslayOptionsEnum' is already declared in the upper scope on line 1 column 13.","line":1,"column":13,"nodeType":"Identifier","messageId":"noShadow","endLine":1,"endColumn":32}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L133
[eslint] reported by reviewdog 🐶 Unexpected string value in conditional. An explicit empty string check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected string value in conditional. An explicit empty string check is required.","line":133,"column":7,"nodeType":"Identifier","messageId":"conditionErrorString","endLine":133,"endColumn":11,"suggestions":[{"messageId":"conditionFixCompareStringLength","fix":{"range":[4823,4828],"text":"name.length === 0"},"desc":"Change condition to check string's length (`value.length !== 0`)"},{"messageId":"conditionFixCompareEmptyString","fix":{"range":[4823,4828],"text":"name === \"\""},"desc":"Change condition to check for empty string (`value !== \"\"`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[4823,4828],"text":"!Boolean(name)"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L175
[eslint] reported by reviewdog 🐶 Unexpected value in conditional. A boolean expression is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected value in conditional. A boolean expression is required.","line":175,"column":7,"nodeType":"Identifier","messageId":"conditionErrorOther","endLine":175,"endColumn":14}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L204
[eslint] reported by reviewdog 🐶 'messages' is already declared in the upper scope on line 131 column 6. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'messages' is already declared in the upper scope on line 131 column 6.","line":204,"column":24,"nodeType":"Identifier","messageId":"noShadow","endLine":204,"endColumn":32}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L211
[eslint] reported by reviewdog 🐶 'itemID' is already declared in the upper scope on line 17 column 10. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'itemID' is already declared in the upper scope on line 17 column 10.","line":211,"column":14,"nodeType":"Identifier","messageId":"noShadow","endLine":211,"endColumn":20}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L268
[eslint] reported by reviewdog 🐶 Unexpected number value in conditional. An explicit zero/NaN check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected number value in conditional. An explicit zero/NaN check is required.","line":268,"column":6,"nodeType":"Identifier","messageId":"conditionErrorNumber","endLine":268,"endColumn":22,"suggestions":[{"messageId":"conditionFixCompareZero","fix":{"range":[10139,10155],"text":"(salveAmuletBoost !== 0)"},"desc":"Change condition to check for 0 (`value !== 0`)"},{"messageId":"conditionFixCompareNaN","fix":{"range":[10139,10155],"text":"(!Number.isNaN(salveAmuletBoost))"},"desc":"Change condition to check for NaN (`!Number.isNaN(value)`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[10139,10155],"text":"(Boolean(salveAmuletBoost))"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L268
[eslint] reported by reviewdog 🐶 Unexpected number value in conditional. An explicit zero/NaN check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected number value in conditional. An explicit zero/NaN check is required.","line":268,"column":26,"nodeType":"Identifier","messageId":"conditionErrorNumber","endLine":268,"endColumn":40,"suggestions":[{"messageId":"conditionFixCompareZero","fix":{"range":[10159,10173],"text":"(blackMaskBoost !== 0)"},"desc":"Change condition to check for 0 (`value !== 0`)"},{"messageId":"conditionFixCompareNaN","fix":{"range":[10159,10173],"text":"(!Number.isNaN(blackMaskBoost))"},"desc":"Change condition to check for NaN (`!Number.isNaN(value)`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[10159,10173],"text":"(Boolean(blackMaskBoost))"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L500
[eslint] reported by reviewdog 🐶 'itemID' is already declared in the upper scope on line 17 column 10. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'itemID' is already declared in the upper scope on line 17 column 10.","line":500,"column":17,"nodeType":"Identifier","messageId":"noShadow","endLine":500,"endColumn":23}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L501
[eslint] reported by reviewdog 🐶 Unexpected number value in conditional. An explicit zero/NaN check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected number value in conditional. An explicit zero/NaN check is required.","line":501,"column":10,"nodeType":"MemberExpression","messageId":"conditionErrorNumber","endLine":501,"endColumn":34,"suggestions":[{"messageId":"conditionFixCompareZero","fix":{"range":[19220,19244],"text":"perKillCost.bank[itemID] !== 0"},"desc":"Change condition to check for 0 (`value !== 0`)"},{"messageId":"conditionFixCompareNaN","fix":{"range":[19220,19244],"text":"!Number.isNaN(perKillCost.bank[itemID])"},"desc":"Change condition to check for NaN (`!Number.isNaN(value)`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[19220,19244],"text":"Boolean(perKillCost.bank[itemID])"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/mahoji/lib/abstracted_commands/minionKill.ts#L552
[eslint] reported by reviewdog 🐶 Unexpected value in conditional. A boolean expression is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected value in conditional. A boolean expression is required.","line":552,"column":7,"nodeType":"Identifier","messageId":"conditionErrorOther","endLine":552,"endColumn":22}