Skip to content

Make getSimilarItems() behavior consistent #13926

Make getSimilarItems() behavior consistent

Make getSimilarItems() behavior consistent #13926

Triggered via pull request October 10, 2023 04:12
Status Success
Total duration 1m 4s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

codequality.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
ESLint
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
ESLint: src/lib/MUser.ts#L395
[eslint] reported by reviewdog 🐶 Unexpected any value in conditional. An explicit comparison or type cast is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected any value in conditional. An explicit comparison or type cast is required.","line":395,"column":9,"nodeType":"ChainExpression","messageId":"conditionErrorAny","endLine":395,"endColumn":23,"suggestions":[{"messageId":"conditionFixCastBoolean","fix":{"range":[11871,11885],"text":"Boolean((equipped?.item))"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/lib/MUser.ts#L587
[eslint] reported by reviewdog 🐶 Unexpected object value in conditional. The condition is always true. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected object value in conditional. The condition is always true.","line":587,"column":54,"nodeType":"Identifier","messageId":"conditionErrorObject","endLine":587,"endColumn":69}
ESLint: src/lib/MUser.ts#L590
[eslint] reported by reviewdog 🐶 Unexpected number value in conditional. An explicit zero/NaN check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected number value in conditional. An explicit zero/NaN check is required.","line":590,"column":36,"nodeType":"MemberExpression","messageId":"conditionErrorNumber","endLine":590,"endColumn":64,"suggestions":[{"messageId":"conditionFixCompareZero","fix":{"range":[18129,18158],"text":"(rawBlowpipeData.dartQuantity === 0)"},"desc":"Change condition to check for 0 (`value !== 0`)"},{"messageId":"conditionFixCompareNaN","fix":{"range":[18129,18158],"text":"(Number.isNaN(rawBlowpipeData.dartQuantity))"},"desc":"Change condition to check for NaN (`!Number.isNaN(value)`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[18129,18158],"text":"(!Boolean(rawBlowpipeData.dartQuantity))"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/lib/MUser.ts#L600
[eslint] reported by reviewdog 🐶 Unexpected number value in conditional. An explicit zero/NaN check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected number value in conditional. An explicit zero/NaN check is required.","line":600,"column":9,"nodeType":"MemberExpression","messageId":"conditionErrorNumber","endLine":600,"endColumn":31,"suggestions":[{"messageId":"conditionFixCompareZero","fix":{"range":[18511,18534],"text":"(rawBlowpipeData.scales === 0)"},"desc":"Change condition to check for 0 (`value !== 0`)"},{"messageId":"conditionFixCompareNaN","fix":{"range":[18511,18534],"text":"(Number.isNaN(rawBlowpipeData.scales))"},"desc":"Change condition to check for NaN (`!Number.isNaN(value)`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[18511,18534],"text":"(!Boolean(rawBlowpipeData.scales))"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/lib/data/similarItems.ts#L361
[eslint] reported by reviewdog 🐶 'similarItems' is already declared in the upper scope on line 356 column 14. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'similarItems' is already declared in the upper scope on line 356 column 14.","line":361,"column":23,"nodeType":"Identifier","messageId":"noShadow","endLine":361,"endColumn":35}
ESLint: src/lib/data/similarItems.ts#L370
[eslint] reported by reviewdog 🐶 'itemID' is already declared in the upper scope on line 1 column 8. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'itemID' is already declared in the upper scope on line 1 column 8.","line":370,"column":33,"nodeType":"Identifier","messageId":"noShadow","endLine":370,"endColumn":47}
ESLint: src/mahoji/lib/abstracted_commands/infernoCommand.ts#L119
[eslint] reported by reviewdog 🐶 'timesMadeToZuk' is already declared in the upper scope on line 118 column 16. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'timesMadeToZuk' is already declared in the upper scope on line 118 column 16.","line":119,"column":8,"nodeType":"Identifier","messageId":"noShadow","endLine":119,"endColumn":22}
ESLint: src/mahoji/lib/abstracted_commands/infernoCommand.ts#L135
[eslint] reported by reviewdog 🐶 'timesMadeToZuk' is already declared in the upper scope on line 118 column 16. Raw Output: {"ruleId":"no-shadow","severity":1,"message":"'timesMadeToZuk' is already declared in the upper scope on line 118 column 16.","line":135,"column":2,"nodeType":"Identifier","messageId":"noShadow","endLine":135,"endColumn":16}
ESLint: src/mahoji/lib/abstracted_commands/infernoCommand.ts#L149
[eslint] reported by reviewdog 🐶 Unexpected number value in conditional. An explicit zero/NaN check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected number value in conditional. An explicit zero/NaN check is required.","line":149,"column":7,"nodeType":"MemberExpression","messageId":"conditionErrorNumber","endLine":149,"endColumn":56,"suggestions":[{"messageId":"conditionFixCompareZero","fix":{"range":[5014,5064],"text":"(sacrificedBank as ItemBank)[itemID('Fire cape')] === 0"},"desc":"Change condition to check for 0 (`value !== 0`)"},{"messageId":"conditionFixCompareNaN","fix":{"range":[5014,5064],"text":"Number.isNaN((sacrificedBank as ItemBank)[itemID('Fire cape')])"},"desc":"Change condition to check for NaN (`!Number.isNaN(value)`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[5014,5064],"text":"!Boolean((sacrificedBank as ItemBank)[itemID('Fire cape')])"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
ESLint: src/mahoji/lib/abstracted_commands/infernoCommand.ts#L242
[eslint] reported by reviewdog 🐶 Unexpected number value in conditional. An explicit zero/NaN check is required. Raw Output: {"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected number value in conditional. An explicit zero/NaN check is required.","line":242,"column":42,"nodeType":"MemberExpression","messageId":"conditionErrorNumber","endLine":242,"endColumn":61,"suggestions":[{"messageId":"conditionFixCompareZero","fix":{"range":[7625,7645],"text":"(blowpipeData.scales === 0)"},"desc":"Change condition to check for 0 (`value !== 0`)"},{"messageId":"conditionFixCompareNaN","fix":{"range":[7625,7645],"text":"(Number.isNaN(blowpipeData.scales))"},"desc":"Change condition to check for NaN (`!Number.isNaN(value)`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[7625,7645],"text":"(!Boolean(blowpipeData.scales))"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}