Forestry basket, Woodcutting boost message + fix #13887
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
codequality.yml
on: pull_request
ESLint
51s
Typescript
1m 1s
Annotations
7 errors and 2 warnings
ESLint:
src/lib/data/creatables/forestryCreatables.ts#L59
[eslint] reported by reviewdog 🐶
Delete `,`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `,`","line":59,"column":19,"nodeType":null,"messageId":"delete","endLine":59,"endColumn":20,"fix":{"range":[1618,1619],"text":""}}
|
ESLint:
src/lib/skilling/functions/determineWoodcuttingTime.ts#L38
[eslint] reported by reviewdog 🐶
Replace `!powerchopping·&&·(user.owns('Forestry·basket',{includeGear:·true})·||·user.owns('Log·basket',{includeGear:·true}))` with `⏎↹↹!powerchopping·&&⏎↹↹(user.owns('Forestry·basket',·{·includeGear:·true·})·||·user.owns('Log·basket',·{·includeGear:·true·}))⏎↹`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `!powerchopping·&&·(user.owns('Forestry·basket',{includeGear:·true})·||·user.owns('Log·basket',{includeGear:·true}))` with `⏎↹↹!powerchopping·&&⏎↹↹(user.owns('Forestry·basket',·{·includeGear:·true·})·||·user.owns('Log·basket',·{·includeGear:·true·}))⏎↹`","line":38,"column":6,"nodeType":null,"messageId":"replace","endLine":38,"endColumn":121,"fix":{"range":[945,1060],"text":"\n\t\t!powerchopping &&\n\t\t(user.owns('Forestry basket', { includeGear: true }) || user.owns('Log basket', { includeGear: true }))\n\t"}}
|
ESLint:
src/mahoji/commands/chop.ts#L166
[eslint] reported by reviewdog 🐶
Expected space or tab after '//' in comment.
Raw Output:
{"ruleId":"spaced-comment","severity":2,"message":"Expected space or tab after '//' in comment.","line":166,"column":3,"nodeType":"Line","messageId":"expectedSpaceAfter","endLine":166,"endColumn":54,"fix":{"range":[4357,4357],"text":" "}}
|
ESLint:
src/mahoji/commands/chop.ts#L169
[eslint] reported by reviewdog 🐶
Replace `{includeGear:·true})·||·user.owns('Log·basket',{includeGear:true` with `·{·includeGear:·true·})·||·user.owns('Log·basket',·{·includeGear:·true·`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `{includeGear:·true})·||·user.owns('Log·basket',{includeGear:true` with `·{·includeGear:·true·})·||·user.owns('Log·basket',·{·includeGear:·true·`","line":169,"column":36,"nodeType":null,"messageId":"replace","endLine":169,"endColumn":100,"fix":{"range":[4484,4548],"text":" { includeGear: true }) || user.owns('Log basket', { includeGear: true "}}
|
ESLint:
src/mahoji/commands/chop.ts#L172
[eslint] reported by reviewdog 🐶
Replace `{includeGear:·true` with `·{·includeGear:·true·`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `{includeGear:·true` with `·{·includeGear:·true·`","line":172,"column":35,"nodeType":null,"messageId":"replace","endLine":172,"endColumn":53,"fix":{"range":[4643,4661],"text":" { includeGear: true "}}
|
ESLint
Error running eslint.
|
ESLint
Process completed with exit code 1.
|
ESLint:
src/mahoji/commands/chop.ts#L83
[eslint] reported by reviewdog 🐶
Unexpected string value in conditional. An explicit empty string check is required.
Raw Output:
{"ruleId":"@typescript-eslint/strict-boolean-expressions","severity":1,"message":"Unexpected string value in conditional. An explicit empty string check is required.","line":83,"column":7,"nodeType":"Identifier","messageId":"conditionErrorString","endLine":83,"endColumn":12,"suggestions":[{"messageId":"conditionFixCompareStringLength","fix":{"range":[1909,1915],"text":"(value.length === 0)"},"desc":"Change condition to check string's length (`value.length !== 0`)"},{"messageId":"conditionFixCompareEmptyString","fix":{"range":[1909,1915],"text":"(value === \"\")"},"desc":"Change condition to check for empty string (`value !== \"\"`)"},{"messageId":"conditionFixCastBoolean","fix":{"range":[1909,1915],"text":"(!Boolean(value))"},"desc":"Explicitly cast value to a boolean (`Boolean(value)`)"}]}
|
ESLint:
src/mahoji/commands/chop.ts#L111
[eslint] reported by reviewdog 🐶
'log' is already declared in the upper scope on line 110 column 9.
Raw Output:
{"ruleId":"no-shadow","severity":1,"message":"'log' is already declared in the upper scope on line 110 column 9.","line":111,"column":4,"nodeType":"Identifier","messageId":"noShadow","endLine":111,"endColumn":7}
|