Skip to content

Commit

Permalink
xen/bootinfo: Include declaration for fw_unreserved_regions()
Browse files Browse the repository at this point in the history
Eclair complains that fw_unreserved_regions() can't see it's declaration.
Include <asm/setup.h> to address this.

This makes Misra Rule 8.4 clean on ARM, so tag it as such.

Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Stefano Stabellini <[email protected]>
  • Loading branch information
andyhhp committed Nov 19, 2024
1 parent 488579e commit 429840a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion automation/eclair_analysis/ECLAIR/tagging.ecl
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ if(string_equal(target,"x86_64"),
)

if(string_equal(target,"arm64"),
service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"})
service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3R1.R8.4||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"})
)

-reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}
Expand Down
2 changes: 2 additions & 0 deletions xen/common/device-tree/bootinfo.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#include <xen/libfdt/libfdt-xen.h>
#include <xen/mm.h>

#include <asm/setup.h>

struct bootinfo __initdata bootinfo = BOOTINFO_INIT;

const char * __init boot_module_kind_as_string(bootmodule_kind kind)
Expand Down

0 comments on commit 429840a

Please sign in to comment.