Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batch support for copy #260

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

wosc
Copy link

@wosc wosc commented May 10, 2024

Note, most/all error handling is missing (notfound, conflict, etc). I'm not sure how the real handling of those cases works, and to be fair, for my simple needs it just did not matter this far, they have all been happy path cases. I currently don't intend to work on this further, but I figured, I'd rather post a rough draft than nothing at all.

Copy link
Owner

@oittaa oittaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgm

@oittaa oittaa self-requested a review August 3, 2024 18:25
Copy link
Owner

@oittaa oittaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's see if the CI runs this time

@wosc
Copy link
Author

wosc commented Aug 7, 2024

I've now tried to fix the linter issues.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.13208% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (679e20d) to head (98d2c6e).
Report is 14 commits behind head on main.

Files Patch % Lines
src/gcp_storage_emulator/handlers/objects.py 81.13% 7 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   86.54%   86.05%   -0.50%     
==========================================
  Files           7        7              
  Lines         892      925      +33     
  Branches      121      122       +1     
==========================================
+ Hits          772      796      +24     
- Misses         92       99       +7     
- Partials       28       30       +2     
Flag Coverage Δ
unittests 86.05% <81.13%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wosc
Copy link
Author

wosc commented Aug 29, 2024

Hrm. Sorry. Somehow the local lint installation behaved differently than the one on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants