-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement batch support for copy #260
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's see if the CI runs this time
I've now tried to fix the linter issues. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 86.54% 86.05% -0.50%
==========================================
Files 7 7
Lines 892 925 +33
Branches 121 122 +1
==========================================
+ Hits 772 796 +24
- Misses 92 99 +7
- Partials 28 30 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hrm. Sorry. Somehow the local lint installation behaved differently than the one on CI. |
Note, most/all error handling is missing (notfound, conflict, etc). I'm not sure how the real handling of those cases works, and to be fair, for my simple needs it just did not matter this far, they have all been happy path cases. I currently don't intend to work on this further, but I figured, I'd rather post a rough draft than nothing at all.