Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enable tags #1076

Closed
wants to merge 7 commits into from
Closed

Feature/enable tags #1076

wants to merge 7 commits into from

Conversation

lbeckman314
Copy link
Member

@lbeckman314 lbeckman314 commented Oct 7, 2024

Overview

This PR includes updated support for task tag propagation to containers!

- Adapted for latest container engine updates, originally from: #709
- Cleaned up tag tests and updated `executeCommand` in docker.go to return the command run as a string (should hopefully make it easier to test this function)
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for ohsu-comp-bio-funnel ready!

Name Link
🔨 Latest commit 15767eb
🔍 Latest deploy log https://app.netlify.com/sites/ohsu-comp-bio-funnel/deploys/6704503494cebd000805b880
😎 Deploy Preview https://deploy-preview-1076--ohsu-comp-bio-funnel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lbeckman314 lbeckman314 self-assigned this Oct 7, 2024
@lbeckman314
Copy link
Member Author

Closing for now in favor of the K8s PR's (#1099 and #1098) but need to revisit/re-open this PR...

@lbeckman314 lbeckman314 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant