Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] adding starship #628

Merged
merged 4 commits into from
Nov 14, 2024
Merged

[Plugin] adding starship #628

merged 4 commits into from
Nov 14, 2024

Conversation

Heus-Sueh
Copy link
Contributor

@Heus-Sueh Heus-Sueh commented Oct 14, 2024

close my own issue: #627

I believe I didn't do anything wrong in the code


Closes #627

@akinomyoga
Copy link
Contributor

akinomyoga commented Oct 14, 2024

starship conflicts with a theme specified by OSH_THEME since both provide PS1. Shouldn't this be implemented as a theme?

@akinomyoga
Copy link
Contributor

In addition, our themes are supposed to be able to switch to another theme when requested, i.e. a theme can be unloaded and another theme can be loaded. Starship can be enabled by eval "$(starship init bash)", but is there a way to unload Starship in a Bash session where Starship was loaded?

@Heus-Sueh
Copy link
Contributor Author

starship conflicts with a theme specified by OSH_THEME since both provide PS1. Shouldn't this be implemented as a theme?

I based it on what ohmyzsh did, which is a plugin instead of a conventional theme

but is there a way to unload Starship in a Bash session where Starship was loaded?

Looking at the starship commands, I didn't find a way to turn it off in an active session

maybe I should add this giant warning:

⚠️ ENABLING THIS PLUGIN WILL UNSET YOUR OSH_THEME VARIABLE

?

@akinomyoga
Copy link
Contributor

Although providing an external theme through a "plugin" instead of a "theme" seems wrong, it should probably better for the consistency with the upstream Oh My Zsh.

@akinomyoga akinomyoga merged commit bea9353 into ohmybash:master Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Plugin] Support to Starship
2 participants