Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep - fix option availability check. #626

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

allan-kg
Copy link
Contributor

@allan-kg allan-kg commented Oct 9, 2024

Description

Checks if the desired grep option is available, properly.

Cause

Executing : | grep "$1" "" >/dev/null 2>&1 always return false on bash 5.2.15(1)-release (x86_64-pc-linux-gnu) @ linux 6.1.0-25-amd64.

It causes problems like:

  • no color for matches
  • including undesired directories

Signed-off-by: Allan Krama Guimarães <[email protected]>
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This is a regression of 4b95670.

lib/grep.sh Outdated Show resolved Hide resolved
@akinomyoga akinomyoga merged commit 1bd9b01 into ohmybash:master Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants