Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes/sirup: Show VirtualEnv #335

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

juanswan13
Copy link
Contributor

Added the ability to show the current Virtual Env when using Python Virtual Env.
If there's not vitual env, the theme works normal.

Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Actually, this type of adjustment of themes depends on personal preferences, so I wouldn't merge it soon unless there is a strong reason that we need to merge it. Rather, we would recommend users customize it personally following the corresponding section in README.

Nevertheless, this PR can be used to demonstrate how to customize the theme, so let me add a label to this PR.

themes/sirup/sirup.theme.sh Outdated Show resolved Hide resolved
@akinomyoga akinomyoga changed the title Show VirtualEnv in Syrup Theme themes/sirup: Show VirtualEnv Jun 23, 2022
juanswan13 and others added 3 commits February 12, 2023 15:36
Added the ability to show the current Virtual Env when using Python Virtual Env.
If there's not vitual env, the theme works normal.
@akinomyoga
Copy link
Contributor

I changed my mind and decided to merge this into master. The background is explained here.

  • I added a commit 3cee730 and rebased.
  • It seems there is already a segment of context information about ruby_gem, so it is more reasonable to put the python_venv information next to the ruby_gem information. I have moved the position of $python_venv to honor the original theme in commit 71d9a1b. I also made the style bold to make it match with ruby_gem.

If there are no further problems or suggestions, I'll wait for a few days and merge this. Thank you!

@akinomyoga akinomyoga merged commit 797da91 into ohmybash:master Feb 16, 2023
@akinomyoga
Copy link
Contributor

Thanks, I have merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants