todos

[akinomyoga]

This is the todo list.

• Check old issues related to the maintenance policy. Ask questions or open discussions if necessary.
  • changes to CONTRIBUTING.md Update CONTRIBUTING.md #269
  • CONTRIBUTING: Proposal #90 Will revisit after Update CONTRIBUTING.md #269 settled.
• Check all the pull requests
• Fix bugs of oh-my-bash.sh. E.g.
  • ${...:t} has a different meaning in Bash, -> oh-my-bash.sh: fix reading of custom/lib files #166
  • fpath=(xxxx $fpath) doesn't work in Bash. Also, there is no alternative for Zsh fpath in Bash. oh-my-bash: Add a function for dependency resolution and refactor #274
  • PROMPT (set by standard.theme and dos.theme) should not be enclosed by \[...\]. To begin with, these themes should set PS1 instead of PROMPT.
  • Configuration for PREVIEW should be moved to lib or plugin although I'm not sure what this settings is for.
• Process small pull requests. I have reviewed almost all of the existing PRs. Wait and see if there is any response to the comments.
• Process large PRs
  • Code improvements #73 in progress
  • refactor: OMB Improvements #270
• Make the coding style consistent
  • Create documents
  • delete trailing spaces
  • consistent indentation
  • func() vs function func etc.
    • cf Git Bash: Terminal starts with error after changing theme #211 (comment)
    • cf Error any time .bashrc is sourced #307 (comment)
    • cf Syntax error on unexpected token (myip function) #364 (comment)
    • cf oh my bash fails to start when start new terminal session #395 (comment)
    • Fix: 59f6ef1
    • We still see divergence between function name { vs function name() {.
  • [ ... ] vs [[ ... ]], quoting inside, == vs =
  • declare and typeset in function scopes
  • Missing locals
  • set -u
  • set -f
• Summarize the upstream repositories of plugins/themes in Wiki or documents
  • Update and merge the changes. Submit PRs to upstream if necessary or applicable
    • completions/git.completion.sh completions/git: bump to v2.34.1 #277 thanks to @jeansebastienh
    • tools/git-prompt.sh
    • Themes seem to be from Bash-it. cf Clean up embedded licensing issues Bash-it/bash-it#1741 and Add LICENSE Bash-it/bash-it#1752
  • Check the copyright of the upstream. We also need to update the copyright notice in README. Not every code in oh-my-bash can be distributed under the MIT license.
• Check conflicting aliases
• Conflicting variables in lib/util.sh and themes/colours.theme.sh -> namespacing
• Summarize all the configuration variables OSH_* and OMB_* used by plugins and themes.
• Why not use bash-completion but define a limited number of completions on its own?
  • bash-completion seems like automatically loaded in lib/bourne-shell.sh
• install: Bash version is checked inside the installation script, but the installation script and the interactive shell are not necessarily the same.
• Avoid aliases by command awk, command sed, command grep, etc.
• OMB_VERSION, --version for install.sh, omb, etc.
• PROMPT_COMMAND
  • Use _omb_util_add_prompt_command instead of directly assigning a value to PROMPT_COMMAND.
  • Allow reloading (related to 028d253). We need to modify _omb_util_add_prompt_command
  • Check compatibility with bash-preexec. (ref add ab+simple theme, tested on termux #195)
• IFS=$OLD_IFS etc causes problems when IFS is originally unset.
• Maybe it is better that we only enable battery in themes when plugin:battery is loaded. Related battery_percentage: command not found #220, tools/upgrade: Return to the original working directory after upgrading #286.
• Check all occurrences of $arr[...]
• _omb_module_require does not check already-loaded files though we implicitly assume that in some places.
• egrep, fgrep deprecated by POSIX

[akinomyoga]

Issues

• The themes axin, binaryanomaly, and sexy are overwriting TERM, which is unusual. It seems to be used to force the later calls of tput to recognize 256 colors.