Dev to master #15
Open
Dev to master #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added optimize button test
pavgra
suggested changes
Sep 13, 2019
| </profile> | ||
| </annotationProcessing> | ||
| <bytecodeTargetLevel> | ||
| <module name="odysseusAT" target="1.8" /> | ||
| <bytecodeTargetLevel target="9"> |
There was a problem hiding this comment.
Why Java 9 in one place and 8th in another (line below)? Or do I get smth wrong?
There was a problem hiding this comment.
What I have to do with it?
| @@ -2,7 +2,7 @@ | |||
| <project version="4"> | |||
There was a problem hiding this comment.
It's common to ignore IDEA generated files
| @@ -19,6 +19,45 @@ | |||
| <orderEntry type="library" scope="TEST" name="Maven: io.cucumber:cucumber-junit:2.3.1" level="project" /> | |||
| <orderEntry type="library" scope="TEST" name="Maven: junit:junit:4.12" level="project" /> | |||
| <orderEntry type="library" scope="TEST" name="Maven: org.hamcrest:hamcrest-core:1.3" level="project" /> | |||
| <orderEntry type="library" name="Maven: net.masterthought:maven-cucumber-reporting:4.7.0" level="project" /> | |||
README.md
Outdated
|
|
||
| **Requirements for running test** | ||
|
|
||
| I need installed JDK and Apache Maven |
There was a problem hiding this comment.
I need? Why not passive form? e.g. It is required to have blah-blah-blah
There was a problem hiding this comment.
It was written by M. Ivanko. I didn't check it. I'll fix it.
README.md
Outdated
| login | ||
| password | ||
| downloadpath | ||
| You have to set correct parameters in *.feature files (blue color), e.g. you have to set existing cohorts |
There was a problem hiding this comment.
You have? Why not passive form? e.g. It is required to set blah-blah-blah
There was a problem hiding this comment.
The same as above
src/test/java/RunCucumberTest.java
Outdated
| (plugin = {"pretty", "json:target/cucumber.json"}, | ||
| glue = {"atlastests"} | ||
| , tags = {"not @ds and not @qds"} | ||
| // , tags = {"@1209"} |
There was a problem hiding this comment.
Because it is configuration, I think I shouldn't remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master 1.0