-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releasing v0.2.4 #350
Draft
chef-danny-d
wants to merge
31
commits into
dev
Choose a base branch
from
0.2.4
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Releasing v0.2.4 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed ALMP-201
Now we only have a single user object that holds all the form data that is entered, this way we can possibly check for errors more easily. In-Progress ALMP-239
fix(user): 🐛 Fixed update user DOB bug
The validator function checks for password matching and min password length. Using the CheckTaken function we also add email errors into the Error object which we pass down into our children components. In the User Info component, I modified the CSS class to be added to each field based on the error field property matching.
In-Progress ALMP-224
…further depth I changed the context to store the object properties directly in the context state rather than it inserting an instructor profile object into the instructor context state.
Using the changes made to the API and the instructor context, we now store and read instructor profiles in the user Profile page. Closes ALMP-224
After getting prompted to log in due to trying to access a Protected route, the user now gets forwarded after login to the path they initially intended to view. Closes ALMP-201
Until we figure out how to fix ALMP-202, this will be on hold.
Added object based error checking to the Register component
Added instructor profile update functionality to Profile component
🐛 (auth): Fixed origin redirects on Login
🚧 (program): Removed ratings from UI
Deploying with Cloudflare Pages
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures are unavailable for this run. For more information, see the Cypress Dashboard This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Before, we were checking for a JWT token and seeing if it was undefined, in the register component. The function that checks the token never returns undefined as for some reason adding that extra check broke the routing from any page to the register page. Fix ALMP-249
Closes ALMP-250
Had to refactor our cypress setup as it had major changed with the upgraded version.
fix(auth): 🚑 Fixed register routing blocker
Upgraded Cypress to v10+
The testing account credentials are used to login cypress when testing the UI. These default values can be overwritten by passing in incorrect credentails, if the test calls for it to fail.
…ck handlers Closes ALMP-248
🧪 Updated failing test cases due to outdated UI references
When the decoder funtion is called, it triggers an if statement that checks if the expiration date in the JWT payload is before or after the current timestamp.
fix(auth): 🐛 Added expiration check for JWT tokens in local storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once merged, we officially finished the
UI: v0.2.4 & API: v0.2.1
sprint.