Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing v0.2.4 #350

Draft
wants to merge 31 commits into
base: dev
Choose a base branch
from
Draft

Releasing v0.2.4 #350

wants to merge 31 commits into from

Conversation

chef-danny-d
Copy link
Collaborator

Once merged, we officially finished the UI: v0.2.4 & API: v0.2.1 sprint.

chef-danny-d and others added 17 commits December 27, 2021 12:42
Now we only have a single user object that holds all the form data that is entered, this way we can possibly check for errors more easily.

In-Progress ALMP-239
fix(user): 🐛 Fixed update user DOB bug
The validator function checks for password matching and min password length. Using the CheckTaken function we also add email errors into the Error object which we pass down into our children components. In the User Info component, I modified the CSS class to be added to each field based on the error field property matching.
…further depth

I changed the context to store the object properties directly in the context state rather than it inserting an instructor profile object into the instructor context state.
Using the changes made to the API and the instructor context, we now store and read instructor profiles in the user Profile page.

Closes ALMP-224
After getting prompted to log in due to trying to access a Protected route, the user now gets forwarded after login to the path they initially intended to view.

Closes ALMP-201
Until we figure out how to fix ALMP-202, this will be on hold.
Added object based error checking to the Register component
Added instructor profile update functionality to Profile component
🐛 (auth): Fixed origin redirects on Login
🚧 (program): Removed ratings from UI
@chef-danny-d chef-danny-d self-assigned this Aug 15, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd54017
Status: ✅  Deploy successful!
Preview URL: https://1e8b6300.emseportal.pages.dev
Branch Preview URL: https://0-2-4.emseportal.pages.dev

View logs

@cypress
Copy link

cypress bot commented Aug 15, 2022



Test summary

30 7 0 0


Run details

Project ALMP
Status Failed
Commit cd54017
Started Aug 24, 2022 8:57 PM
Ended Aug 24, 2022 9:00 PM
Duration 03:42 💡
OS Linux Ubuntu - 20.04
Browser Firefox 103

View run in Cypress Dashboard ➡️

Failures are unavailable for this run. For more information, see the Cypress Dashboard


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

chef-danny-d and others added 10 commits August 16, 2022 10:59
Before, we were checking for a JWT token  and seeing if it was undefined, in the register component. The function that checks the token never returns undefined as for some reason adding that extra check broke the routing from any page to the register page.

Fix ALMP-249
Had to refactor our cypress setup as it had major changed with the upgraded version.
fix(auth): 🚑 Fixed register routing blocker
The testing account credentials are used to login cypress when testing the UI. These default values can be overwritten by passing in incorrect credentails, if the test calls for it to fail.
chef-danny-d and others added 4 commits August 24, 2022 16:01
🧪 Updated failing test cases due to outdated UI references
When the decoder funtion is called, it triggers an if statement that checks if the expiration date in the JWT payload is before or after the current timestamp.
fix(auth): 🐛 Added expiration check for JWT tokens in local storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant