Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💣 BIG BANG : Migrate Material 2 -> 3 + Design System + Data exclusion logic + Minor tweaks #77

Merged
merged 30 commits into from
Mar 12, 2024

Conversation

odaridavid
Copy link
Owner

@odaridavid odaridavid commented Mar 11, 2024

Related Issue

Description

Improve the confusion that was the ui components + styling + design system + much more, this sets the foundation for my other ideas.

How Can It Be Tested

Note to self : Could have been easier with snapshot/ui tests.

Screenshots (If Applicable)

Additional Comments

Checklist

  • New tests were added/Existing Modified

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 68.33333% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 69.81%. Comparing base (afc11c4) to head (ab09419).

Files Patch % Lines
...therapp/data/settings/DefaultSettingsRepository.kt 0.00% 8 Missing ⚠️
...idavid/weatherapp/ui/settings/SettingsViewModel.kt 78.37% 2 Missing and 6 partials ⚠️
...aridavid/weatherapp/data/weather/remote/Mappers.kt 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #77      +/-   ##
=============================================
+ Coverage      60.50%   69.81%   +9.31%     
- Complexity        35       45      +10     
=============================================
  Files             23       22       -1     
  Lines            476      487      +11     
  Branches          44       49       +5     
=============================================
+ Hits             288      340      +52     
+ Misses           175      126      -49     
- Partials          13       21       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odaridavid odaridavid merged commit 5069f18 into develop Mar 12, 2024
6 checks passed
@odaridavid odaridavid deleted the dd-exclusion branch March 12, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Permission Handling UI [FEATURE] Give user ability to decide what data to exclude
1 participant