Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider to match the rest of octodns-* #14

Merged
merged 8 commits into from
Nov 12, 2023
Merged

Conversation

ross
Copy link
Contributor

@ross ross commented Nov 8, 2023

There are no actual code changes here, just a pass that brings everything in line with how all the other octodns modules are laid out and work. This should allow all the existing tooling/processes to apply cleanly to this provider so that it's not left behind (as it has been up to this point.)

/cc #13 (comment) @istr

@ross ross self-assigned this Nov 8, 2023
@ross
Copy link
Contributor Author

ross commented Nov 8, 2023

Will have to look into why 3.8 is failing later, I'm out of time today. Part of the resaon for making this switch to bring things in line is to get all the full testing setup and find stuff like this.

@istr
Copy link
Contributor

istr commented Nov 9, 2023

Will have to look into why 3.8 is failing later, I'm out of time today. Part of the resaon for making this switch to bring things in line is to get all the full testing setup and find stuff like this.

See https://stackoverflow.com/questions/66846743/importerror-cannot-import-name-cache-from-functools and https://docs.python.org/3/library/functools.html#functools.cache.

I pushed a commit to this branch to change this.

However, it seems that there are some more backwards compatibility issues to be fixed.

@istr
Copy link
Contributor

istr commented Nov 9, 2023

@ross only removesuffix needed to be replaced. So we are all set.

I think the suffix = "." + zone.name[:-1] is safe, since the zone name is guaranteed to end with a dot.
But you might want to review, just in case.

@ross
Copy link
Contributor Author

ross commented Nov 12, 2023

@ross only removesuffix needed to be replaced. So we are all set.

Thanks for the fixes!

@ross
Copy link
Contributor Author

ross commented Nov 12, 2023

Moving forward with this now. Should allow us to keep everything in sync going forward. Again no actual changes to the code/functionality should have been made as part of this. It's just making everything surrounding the code, setup.py, readme, changelog, versioning, ... line up with everything else.

@ross ross merged commit 9fa47a9 into main Nov 12, 2023
9 checks passed
@ross ross deleted the work-like-others branch November 12, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants