-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Mega refactor + start Clang rules + add property configuration to UI #97
Open
mjdetullio
wants to merge
43
commits into
octo-technology:master
Choose a base branch
from
mjdetullio:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and measure persistor class created to save the measures of the lizard repor.
… values are displayed as 0 in the dashboard. Trying to savin complexity throws exception -> Can not add the same measure twice on org.sonar.api.resources.File ...
…uld actually do because it was causing that saving comlexity and functions for files throw exception. Lizard measure now saves the measures succesfully
…dSensor to LizardMeasurePersistor
…iveCSquidSensor to LizardReportParser.
…jective-c into lizard_complexity
… the lizard report is not found, allowing the execution of the plugin without lizard
Intended to be used with xcodebuild's 'analyze' action, allows setting the sonar.objectivec.clang.reportsPath property to the directory containing the Clang plist report files.
mjdetullio
force-pushed
the
master
branch
8 times, most recently
from
November 4, 2015 18:21
4c53754
to
efc1f09
Compare
This was referenced Jan 28, 2016
mjdetullio
force-pushed
the
master
branch
4 times, most recently
from
March 6, 2016 21:29
46536f0
to
876b99d
Compare
mjdetullio
force-pushed
the
master
branch
7 times, most recently
from
March 9, 2016 01:40
68c8e7c
to
5944873
Compare
mjdetullio
force-pushed
the
master
branch
4 times, most recently
from
March 16, 2016 19:01
9c3eef7
to
35fc85b
Compare
What's the status of this PR? I'm very interested in the clang rules. Looks like there is a lot changing here. |
This work was primarily for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I based these changes on the Lizard code which haven't been merged yet, so this includes that.
My changes touch essentially every class and will create merge hell for everyone, so I wouldn't recommend merging. This is here more or less for the visibility into the work.
Anyway, this refactoring removes 99% of your use of deprecated APIs and brings the code more inline with many other plugins. This will also fix some of the issues logged here but I don't have a comprehensive list.