PullRequest: 495 Fixes oceanbase/odc#3105

Merge branch 'fix/dev-4.3.1-3105 of [email protected]:oceanbase/oceanbase-developer-center.git into dev-4.3.1 https://code.alipay.com/oceanbase/oceanbase-developer-center/pull_requests/495 Signed-off-by: 晓康 <[email protected]> * Fixes oceanbase/odc#3105
oceanbase · Aug 6, 2024 · b40ca0e · b40ca0e
1 parent 571246b
commit b40ca0e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/src/common/network/project.ts b/src/common/network/project.ts
@@ -51,7 +51,7 @@ export async function getProject(id: number): Promise<IProject> {
   return res?.data;
 }
 
-export async function getProjectHistoryInfo(id: number): Promise<IProject> {
+export async function getProjectWithErrorCatch(id: number): Promise<IProject> {
   const res = await request.get(`/api/v2/collaboration/projects/${id}`, {
     params: {
       ignoreError: true,

diff --git a/src/component/Task/DetailModal.tsx b/src/component/Task/DetailModal.tsx
@@ -66,7 +66,7 @@ import { ApplyDatabasePermissionTaskContent } from './ApplyDatabasePermission';
 import { ApplyTablePermissionTaskContent } from './ApplyTablePermission';
 import { StructureComparisonTaskContent } from './StructureComparisonTask';
 import { MutipleAsyncTaskContent } from './MutipleAsyncTask';
-import { getProject } from '@/common/network/project';
+import { getProjectWithErrorCatch } from '@/common/network/project';
 import { ProjectRole } from '@/d.ts/project';
 import userStore from '@/store/login';
 import { isNumber } from 'lodash';
@@ -144,10 +144,10 @@ const DetailModal: React.FC<IProps> = React.memo((props) => {
       setIsTaskProjectOwner(false);
       return;
     }
-    const res = await getProject(projectId);
-    const userRoleList = res?.members
-      ?.filter((i) => i.id === userStore?.user?.id)
-      ?.map((j) => j.role);
+
+    const res = await getProjectWithErrorCatch(projectId);
+    const userRoleList =
+      res?.members?.filter((i) => i.id === userStore?.user?.id)?.map((j) => j.role) || [];
     setIsTaskProjectOwner(userRoleList.includes(ProjectRole.OWNER));
   };
 

diff --git a/src/component/Task/component/ActionBar/index.tsx b/src/component/Task/component/ActionBar/index.tsx
@@ -92,7 +92,6 @@ const ActionBar: React.FC<IProps> = inject(
     } = props;
     const isOwner = user?.id === task?.creator?.id;
     const isApprover = task?.approvable;
-    const isCandidateApprovers = task?.candidateApprovers;
     const isOwnerAndApprover = isOwner && isApprover;
     const [activeBtnKey, setActiveBtnKey] = useState(null);
     const [openRollback, setOpenRollback] = useState(false);
@@ -843,7 +842,7 @@ const ActionBar: React.FC<IProps> = inject(
           handleApproval(false);
         },
       };
-      const isOperator = isOwner || isCandidateApprovers;
+      const isOperator = isOwner || isTaskProjectOwner;
       switch (status) {
         case TaskStatus.APPROVING: {
           if (isOperator && isApprover) {

diff --git a/src/service/projectHistory.ts b/src/service/projectHistory.ts
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { getProjectHistoryInfo } from '@/common/network/project';
+import { getProjectWithErrorCatch } from '@/common/network/project';
 import login from '@/store/login';
 import logger from '@/util/logger';
 import { safeParseJson } from '@/util/utils';
@@ -54,7 +54,7 @@ export async function toDefaultProjectPage() {
   if (!projectId) {
     history.push('/project');
   } else {
-    const project = await getProjectHistoryInfo(projectId);
+    const project = await getProjectWithErrorCatch(projectId);
     const isProjectAvailable = project && !project?.archived;
     isProjectAvailable ? history.push(`/project/${projectId}/database`) : history.push('/project');
   }