修复 bplus_tree_test 单测问题 #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem were solved in this pull request?
Problem:
问题1：bplus_tree_test 单测失败，内存非法访问
问题2：bplus_tree_log_test concurrency 单测失败
What is changed and how it works?
问题1：单测运行时ASAN报内存非法访问。由于BplusTreeMiniTransaction析构时自动调用BplusTreeLogger的析构，接着调用 BplusTreeLogger::commit，这里会访问Frame，而frame已经释放，这样造成的内存非法访问。
问题2：build.sh 没有传入-DCONCURRENCY参数
修复方法：
BplusTreeMiniTransaction 构造函数不给出rc时不自动提交或回滚，BplusTreeLogger也不需要在析构时自动提交。