Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in lex_sql.l #470

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix typo in lex_sql.l #470

merged 2 commits into from
Oct 25, 2024

Conversation

ZJY0516
Copy link
Contributor

@ZJY0516 ZJY0516 commented Oct 24, 2024

What problem were solved in this pull request?

在lex_sql.l中，WHITE_SPACE被写成了WHITE_SAPCE

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nautaa
nautaa approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@nautaa nautaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hnwyllmm
hnwyllmm requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@hnwyllmm hnwyllmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request, but you should execute gen_parser.sh to generate new cpp code files.

hnwyllmm
hnwyllmm approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@hnwyllmm hnwyllmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnwyllmm hnwyllmm merged commit e1aa56d into oceanbase:main Oct 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nautaa nautaa nautaa approved these changes

@hnwyllmm hnwyllmm hnwyllmm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZJY0516 @CLAassistant @hnwyllmm @nautaa