Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocaml src updates #26972

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ocaml src updates #26972

wants to merge 2 commits into from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Nov 27, 2024

No description provided.

@hannesm hannesm mentioned this pull request Nov 27, 2024
Open
@hannesm
Copy link
Member Author

hannesm commented Nov 27, 2024

If I understand it correctly, @avsm proposed such a change in #26947.

@hannesm
Copy link
Member Author

hannesm commented Nov 28, 2024

from my point of view, this is good to merge

shym
shym approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@shym shym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
(I’ve checked in particular that no ocaml-src package was forgotten in the first commit.)

@hannesm
Copy link
Member Author

hannesm commented Nov 28, 2024

anything needed from my site to merge now that there's a consider-for-merge label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shym shym shym approved these changes

Assignees
No one assigned
Labels
consider for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannesm @shym @mseri