Improvements to benchmarks and profiling #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Guillaume Petiot <[email protected]>
Report the time taken by the command that took the most time as a separate metric. Co-authored-by: Guillaume Petiot <[email protected]>
|
I'll merge this as it only touch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit comment-out a command that should have been.
The second commit gives predictable and useful names to landmarks output files. Previously, names contained random numbers.
The third commit adds a benchmarks: The time spent running the slowest command. This metric might help recognize large performance regressions in rare cases that we might have missed otherwise.