Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llm-introduction-attention-transformer and an assginment of transformer without hollowing #735

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

penjc
Copy link
Contributor

@penjc penjc commented Mar 26, 2024

Description

Add new chapter llm. Complete introduction, attention, transformer and an assignment of transformer without hollowing. Modify the configuation files _config and _toc.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have applied tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@penjc
Copy link
Contributor Author

penjc commented Mar 26, 2024

shoule the images be uploaded to cosbrowser?

@penjc penjc closed this Mar 26, 2024
@penjc penjc reopened this Mar 26, 2024
Copy link
Contributor

@Lola-jo Lola-jo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@Lola-jo
Copy link
Contributor

Lola-jo commented Mar 28, 2024

shoule the images be uploaded to cosbrowser?

Yes. COS key please see ocademy group announcement.

it's important !!!!!!

Copy link
Contributor

@Lola-jo Lola-jo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think perhaps these would be better placed in the "deep learning" as a small chapter, and could be expanded on slightly within the chapter.

@penjc penjc force-pushed the llm branch 3 times, most recently from 899851f to 031c6f2 Compare April 7, 2024 05:05
Copy link
Contributor

@Lola-jo Lola-jo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@Lola-jo Lola-jo merged commit bb6bfb2 into ocademy-ai:main Apr 9, 2024
1 check passed
@penjc penjc deleted the llm branch April 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants