-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llm-introduction-attention-transformer and an assginment of transformer without hollowing #735
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
shoule the images be uploaded to cosbrowser? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
open-machine-learning-jupyter-book/assignments/llm/basic/transformer-architecture.ipynb
Outdated
Show resolved
Hide resolved
open-machine-learning-jupyter-book/assignments/llm/basic/transformer-architecture.ipynb
Outdated
Show resolved
Hide resolved
Yes. COS key please see ocademy group announcement. it's important !!!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think perhaps these would be better placed in the "deep learning" as a small chapter, and could be expanded on slightly within the chapter.
899851f
to
031c6f2
Compare
open-machine-learning-jupyter-book/assignments/llm/basic/transformer-architecture.ipynb
Show resolved
Hide resolved
open-machine-learning-jupyter-book/assignments/llm/basic/transformer-architecture.ipynb
Show resolved
Hide resolved
open-machine-learning-jupyter-book/assignments/llm/basic/transformer-architecture.ipynb
Show resolved
Hide resolved
open-machine-learning-jupyter-book/assignments/llm/basic/transformer-architecture.ipynb
Show resolved
Hide resolved
open-machine-learning-jupyter-book/assignments/llm/basic/transformer-architecture.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Description
Add new chapter llm. Complete introduction, attention, transformer and an assignment of transformer without hollowing. Modify the configuation files _config and _toc.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: