Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update first-party GitHub Actions to v4 #1200

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Jan 31, 2024

Description

CI: Update first-party GitHub Actions to v4

GitHub Actions has deprecated actions based on node16. The v4 actions are based on node20. Replace first-party v2/v3 actions with their v4 counterparts.

GitHub Actions has deprecated actions based on node12 and forces them to run on node16, which is also deprecated. Update to v4 actions to avoid warnings on CI.

See:

Motivation and Context

Want less CI warnings and don't want CI to stop working when node12/node16 are disabled.

How Has This Been Tested?

This is on CI. obs-deps, obs-studio, obs-browser, and obs-plugintemplate have had successful runs with updated first-party actions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Other Enhancement (anything not applicable to what is listed)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

GitHub Actions has deprecated actions based on node16. The v4 actions
are based on node20. Replace first-party v2/v3 actions with their v4
counterparts.

GitHub Actions has deprecated actions based on node12 and forces them to
run on node16, which is also deprecated. Update to v4 actions to avoid
warnings on CI.

See:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
@RytoEX RytoEX requested a review from tt2468 January 31, 2024 00:19
@RytoEX
Copy link
Member Author

RytoEX commented Jan 31, 2024

It does look like sometimes we use lowercase ci: here for a prefix. Let me know if this needs to be changed.

Copy link
Member

@tt2468 tt2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too picky about commit prefixes for stuff like this, so that's fine.

@tt2468 tt2468 merged commit e94f919 into obsproject:master Jan 31, 2024
1 check passed
@RytoEX RytoEX deleted the update-actions branch January 31, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants