Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add HotkeyBlocker class #9981

Closed
wants to merge 1 commit into from
Closed

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Dec 10, 2023

Description

This adds a HotkeyBlocker class that is similar to SignalBlocker. It is used when selection dialogs are opened and because they are modal, hotkeys shouldn't be able to be used.

Motivation and Context

Simpler alternative to #8725

Fixes #7824

How Has This Been Tested?

Opened file dialog from image context bar widget and made sure hotkeys were disabled when browsing and re-enabled when it was closed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Dec 10, 2023
@cg2121 cg2121 force-pushed the hotkey-blocker branch 3 times, most recently from d8e5455 to ad7f35f Compare December 10, 2023 03:55
@cg2121 cg2121 marked this pull request as draft December 10, 2023 11:23
@cg2121
Copy link
Contributor Author

cg2121 commented Dec 10, 2023

Converted to draft, as I need to figure out why it doesn't compile on Windows and macOS.

@cg2121
Copy link
Contributor Author

cg2121 commented Dec 11, 2023

#9989 should fix the compiling issue, so that one needs to be merged first.

This adds a HotkeyBlocker class that is similar to SignalBlocker.
It is used when selection dialogs are opened and because they are
modal, hotkeys shouldn't be able to be used.
@cg2121
Copy link
Contributor Author

cg2121 commented Aug 20, 2024

Found a way to accomplish this in #7924

@cg2121 cg2121 closed this Aug 20, 2024
@cg2121 cg2121 deleted the hotkey-blocker branch August 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OBS Crashes when switching scenes by hotkey and an Image source file dialog box is open
2 participants