Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix autoconfig saving signed stream key #11532

Conversation

dsaedtler
Copy link
Contributor

Description

Fixes the auto config wizard saving the signed stream key when testing with multitrack video enabled.

Since we don't use the MT config anyway for the bandwidth test there's no reason to save or use the key returned by the API.

Motivation and Context

Reported on TEB Discord by a Linux user (OAuth wasn't available in initial Flatpak builds).

How Has This Been Tested?

Locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I suppose if the bandwidth test is ever changed to use Multitrack Video, then this can be re-added/re-implemented.

@RytoEX RytoEX added this to the OBS Studio 31 milestone Nov 18, 2024
@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Nov 19, 2024
@RytoEX RytoEX merged commit 1648dcc into obsproject:master Nov 19, 2024
14 checks passed
@dsaedtler dsaedtler deleted the rodney/fix-mt-autoconfig-stream-key branch November 21, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants