Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix outdated scene collection and profile method names #11284

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

PatTheMav
Copy link
Member

Description

Fixes method names for certain scene collection and frontend methods exposed via the frontend API that had been renamed during review phase of #11055.

Motivation and Context

Restores functionality of the corresponding frontend API methods.

Note

Plugins which invoke public slot functions on the UI thread directly instead of using the frontend API will face the same issue. Luckily this should not result in crashes or other issues at runtime as Qt will just ignore the call and at worst post a log message about a non-existing method being invoked.

How Has This Been Tested?

Tested with a simple plugin that invokes the corresponding frontend API functions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@PatTheMav PatTheMav added the Bug Fix Non-breaking change which fixes an issue label Sep 14, 2024
@RytoEX RytoEX added this to the OBS Studio 31 milestone Sep 16, 2024
@RytoEX RytoEX merged commit b9808ea into obsproject:master Sep 16, 2024
14 checks passed
@PatTheMav PatTheMav deleted the frontend-api-fix branch September 17, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants