-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent git clone / wget issues during re-run of install.sh #13
base: master
Are you sure you want to change the base?
Conversation
He does not need to clone my repository, he can merge it into his. So perhaps this PR should wait until he merges in my PR. |
Done! Forgive me, I manually redid your changes as I didn't see in time that you actually submitted them. But they're all in. Thank you! |
Thanks for the suggestions. Due to the other in-progress changes, I have removed my updates related to the Remaining fixes as described in the original PR comment are still present. |
Personally I don't see any need to clone my repository. The panama code is about 2 years old and is missing many bug fixes since then. My sims repository is a development repository so there might be changes there that could break the simulator. This is why I don't copy all changes to open-simh right away. I have no problem maintaining second repository and pushing changes down as they pass testing. |
Addresses #12 andsome comments from https://groups.google.com/g/pidp-10/c/csbzz40gSQA/m/fwibojMWAQAJMinor installer improvements:
Removes the destination folder forgit clone
of https://github.com/rcornwell/pidp10 if it already exists. Resolves an error that happens if you re-run the installer script.wget
to prevent multiple copies of the file from accumulating if you re-run the installer script.-->
in an unquoted string. This was an issue because it is interpreted by the shell as an output redirection.Cosmetic changes:
-y install
vsinstall -y
Open Questions:
apt
and sometimesapt-get
- not sure if this is intentionalwget
unzip
setcap
(provided bylibcap2-bin
in Ubuntu)The same issue withgit clone
may also happen with https://github.com/PDP-10/its.git