-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Post Webhook #4708
base: master
Are you sure you want to change the base?
Add plugin: Post Webhook #4708
Conversation
Hello!I found the following issues in your plugin submission Errors: ❌ Could not parse This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ Please don't use the word This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:Please remove the Do NOT open a new PR for re-validation. |
Changes requested by bot have been made, assigning human for additional review. |
# Obsidian Post Webhook Plugin i.a. webhook, webhook, webhook, webhook containerEl.createEl('h2', {text: 'Post Webhook Settings'}); const parsedYaml = YAML.parse(yamlContent); static arrayBufferToBase64(buffer) { const response = await fetch(webhookUrl, { static parseYamlFrontmatter(content) { const info = getFrontMatterInfo(content);
if (!info.exists) {
return {
frontmatter: {},
content
}
}
const frontmatter = parseYaml(info.frontmatter);
const content = content.slice(info.contentStart);
return {
frontmatter,
content
} static async getAttachments(app, content, notePath) { static async getAttachments(app, file) {
const cache = app.metadataCache.getFileCache(file);
if (!cache) {
//throw error
}
for (embed in cache.embeds) {
const link = this.app.metadataCache.getFirstLinkpathDest(embed.link);
file = this.app.vault.getFileByPath(link);
if (file) {
//process file
}
}
//same logic as above for `cache.links`
} Note that this code requires you to increase your |
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
@joethei, I've implemented the changes you suggested (release v1.0.2). Please have a look when you have a chance. Thank you for your helpful feedback! |
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/Masterb1234/obsidian-post-webhook/
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.